-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for nested types #54
Support for nested types #54
Conversation
Signed-off-by: Francisco Martin Rico <fmrico@gmail.com>
@fmrico thanks! Could you add some tests to this PR? |
Ok!! It will take me some time, but I will start working now on it. |
Signed-off-by: Francisco Martin Rico <fmrico@gmail.com>
Hi @esteve , Tests added, but it depends on ros2-dotnet/dotnet_cmake_module#2 Best!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor points but otherwise looks great; thanks for doing the work and for rebasing it again after the Eloquent changes!!
Thanks for this change, and also for laying the groundwork to do some unit testing. |
…_get_dotnet_type_patch Extend get_dotnet_type to handle nested types
Signed-off-by: Francisco Martin Rico <fmrico@gmail.com>
Signed-off-by: Francisco Martin Rico <fmrico@gmail.com>
Signed-off-by: Francisco Martin Rico <fmrico@gmail.com>
I think that everything is pushed to PR, both here and in dotnet_cmake_module. Thanks to you for your comments and revisions!!! I am willing to start working in the collections :) |
Hi!!
This PR provides support for nested types.
Best
Signed-off-by: Francisco Martin Rico fmrico@gmail.com